Re: [PATCH] crypto: nx - annotate struct nx842_crypto_header with __counted_by

From
Gustavo A. R. Silva <hidden>
Date
2026-03-17 23:37:12
Also in
linux-crypto, linux-hardening, lkml
Reply to
Thorsten Blum, 2026-03-17

On 3/17/26 14:18, Thorsten Blum wrote:
Add the __counted_by() compiler attribute to the flexible array member
'group' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
CONFIG_FORTIFY_SOURCE.

Signed-off-by: Thorsten Blum <redacted>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks
-Gustavo
quoted hunk ↗ jump to hunk
---
  drivers/crypto/nx/nx-842.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/nx/nx-842.h b/drivers/crypto/nx/nx-842.h
index f5e2c82ba876..a04e85e9f78e 100644
--- a/drivers/crypto/nx/nx-842.h
+++ b/drivers/crypto/nx/nx-842.h
@@ -164,7 +164,7 @@ struct nx842_crypto_header {
  		__be16 ignore;		/* decompressed end bytes to ignore */
  		u8 groups;		/* total groups in this header */
  	);
-	struct nx842_crypto_header_group group[];
+	struct nx842_crypto_header_group group[] __counted_by(groups);
  } __packed;
  static_assert(offsetof(struct nx842_crypto_header, group) == sizeof(struct nx842_crypto_header_hdr),
  	      "struct member likely outside of struct_group_tagged()");
  
Thread (3 messages) 3 messages, 3 authors, last reply 2026-03-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help