Re: [PATCH v3] bus: fsl-mc: fix an error handling in fsl_mc_device_add()
From: Ioana Ciornei <ioana.ciornei@nxp.com>
Date: 2026-01-28 12:15:09
Also in:
lkml, stable
On Sat, Jan 24, 2026 at 06:20:54PM +0800, Haoxiang Li wrote:
In fsl_mc_device_add(), device_initialize() is called first.
put_device() should be called to drop the reference if error
occurs. And other resources would be released via put_device
-> fsl_mc_device_release. So remove redundant kfree() in
error handling path.
Fixes: bbf9d17d9875 ("staging: fsl-mc: Freescale Management Complex (fsl-mc) bus driver")
Cc: stable@vger.kernel.org
Reported-by: Dan Carpenter <redacted>
Closes: https://lore.kernel.org/all/b767348e-d89c-416e-acea-1ebbff3bea20@stanley.mountain/ (local)
Signed-off-by: Su Hui <redacted>
Suggested-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
Signed-off-by: Haoxiang Li <redacted>Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>