Thread (11 messages) 11 messages, 3 authors, 2026-01-21

Re: [PATCH v2 1/4] ASoC: dt-bindings: fsl,audmix: Add support for i.MX952 platform

From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: 2026-01-20 11:08:01
Also in: imx, linux-arm-kernel, linux-devicetree, linux-sound, lkml

On Tue, Jan 20, 2026 at 6:31 PM Krzysztof Kozlowski [off-list ref] wrote:
On Tue, Jan 20, 2026 at 11:52:07AM +0800, Shengjiu Wang wrote:
quoted
There is no power domain defined on i.MX952, so make power-domains to be
There is no defined or there is no power domain? If the first, then this
patch is incomplete. Please read writing bindings part about complete
bindings. If the latter, then you miss constraints ":false" and commit
msg phrasing is incorrect (and remember that in such case you won't be
able to add power domains later because now you add complete binding).
Thanks for pointing this out.

There is a power domain on i.MX952 for the mix system of AUDMIX.
But it is enabled by default,  AUDMIX device don't need to enable it.
So can we make the power-domains to be optional for this case?

Best regards
Shengjiu Wang
quoted
dedicated to i.MX8QM.

Signed-off-by: Shengjiu Wang <redacted>
---
Best regards,
Krzysztof
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help