Re: [PATCH v2 01/11] mm/migrate_device: Introduce migrate_pfn_from_page() helper

On 2026-01-08 18:49, Jordan Niethe wrote:

Hi,

On 9/1/26 07:03, Felix Kuehling wrote:

quoted

quoted

@@ -646,7 +646,7 @@ svm_migrate_copy_to_ram(struct amdgpu_device 

*adev, struct svm_range *prange,
          pr_debug_ratelimited("dma mapping dst to 0x%llx, pfn 
0x%lx\n",
                       dst[i] >> PAGE_SHIFT, page_to_pfn(dpage));
-        migrate->dst[i] = migrate_pfn(page_to_pfn(dpage));
+        migrate->dst[i] = migrate_pfn_from_page(dpage);

You missed another instance of this in svm_migrate_copy_to_vram.

I might be missing something, but is there call to migrate_pfn() in
svm_migrate_copy_to_vram()? 

I see what's happening. You removed that call in patch 2. Never mind.

Regards,
   Felix

I'm seeing svm_migrate_copy_to_vram() calls
svm_migrate_addr_to_mpfn() - that should be handled already.

Thanks for reviewing,
Jordan.

quoted

Regards,
   Felix