Re: [PATCH 02/11] ARM: at91: Simplify with scoped for each OF child loop
From: Nicolas Ferre <nicolas.ferre@microchip.com>
Date: 2026-01-05 13:41:55
Also in:
dmaengine, imx, linux-arm-kernel, linux-clk, linux-devicetree, linux-media, linux-pm, linux-samsung-soc, lkml, llvm
Krzysztof, On 05/01/2026 at 14:33, Krzysztof Kozlowski wrote:
Use scoped for-each loop when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski <redacted>
Thanks for handling this! Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Best regards, Nicolas
quoted hunk ↗ jump to hunk
--- Depends on the first patch. --- arch/arm/mach-at91/pm.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 35058b99069c..68bb4a86cd94 100644 --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c@@ -982,15 +982,12 @@ static void __init at91_pm_sram_init(void) struct gen_pool *sram_pool; phys_addr_t sram_pbase; unsigned long sram_base; - struct device_node *node; struct platform_device *pdev = NULL; - for_each_compatible_node(node, NULL, "mmio-sram") { + for_each_compatible_node_scoped(node, NULL, "mmio-sram") { pdev = of_find_device_by_node(node); - if (pdev) { - of_node_put(node); + if (pdev) break; - } } if (!pdev) { --2.51.0