Re: [PATCH] KVM: Remove subtle "struct kvm_stats_desc" pseudo-overlay
From: Gustavo A. R. Silva <hidden>
Date: 2025-12-06 03:38:53
Also in:
kvm, kvm-riscv, kvmarm, linux-arm-kernel, linux-mips, linux-riscv, lkml, loongarch
On 12/6/25 08:26, Sean Christopherson wrote:
Remove KVM's internal pseudo-overlay of kvm_stats_desc, which subtly aliases the flexible name[] in the uAPI definition with a fixed-size array of the same name. The unusual embedded structure results in compiler warnings due to -Wflex-array-member-not-at-end, and also necessitates an extra level of dereferencing in KVM. To avoid the "overlay", define the uAPI structure to have a fixed-size name when building for the kernel.
Nice. Thanks for this.
Opportunistically clean up the indentation for the stats macros, and replace spaces with tabs. No functional change intended. Reported-by: Gustavo A. R. Silva <gustavoars@kernel.org> Closes: https://lore.kernel.org/all/aPfNKRpLfhmhYqfP@kspp (local) Signed-off-by: Sean Christopherson <seanjc@google.com>
Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org> -Gustavo