Re: [PATCH 2/2] treewide: Drop pci_save_state() after pci_restore_state()
From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Date: 2025-11-05 14:34:13
Also in:
linux-pci
From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Date: 2025-11-05 14:34:13
Also in:
linux-pci
On Sun, Oct 12, 2025 at 02:25:02PM +0100, Lukas Wunner wrote:
In 2009, commit c82f63e411f1 ("PCI: check saved state before restore")
changed the behavior of pci_restore_state() such that it became necessary
to call pci_save_state() afterwards, lest recovery from subsequent PCI
errors fails.
The commit has just been reverted and so all the pci_save_state() after
pci_restore_state() calls that have accumulated in the tree are now
superfluous. Drop them.
Two drivers chose a different approach to achieve the same result:
drivers/scsi/ipr.c and drivers/net/ethernet/intel/e1000e/netdev.c set the
pci_dev's "state_saved" flag to true before calling pci_restore_state().
Drop this as well.
Signed-off-by: Lukas Wunner <lukas@wunner.de>For the changes in the QAT driver: Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> [qat] Regards, -- Giovanni