Thread (15 messages) 15 messages, 4 authors, 2025-11-21

Re: [PATCH 5/6 v7] acpi/ghes: Add helper to copy CXL protocol error info to work struct

From: Hanjun Guo <guohanjun@huawei.com>
Date: 2025-11-21 02:22:44
Also in: linux-acpi, linux-cxl, linux-pci, lkml

On 2025/11/5 2:22, Fabio M. De Francesco wrote:
quoted hunk ↗ jump to hunk
Make a helper out of cxl_cper_post_prot_err() that checks the CXL agent
type and copy the CPER CXL protocol errors information to a work data
structure.

Export the new symbol for reuse by ELOG.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Fabio M. De Francesco <redacted>
---
  drivers/acpi/apei/ghes.c | 42 ++++++++++++++++++++++++++--------------
  include/cxl/event.h      | 10 ++++++++++
  2 files changed, 37 insertions(+), 15 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index e69ae864f43d..2f4632d9855a 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -734,20 +734,12 @@ int cxl_cper_sec_prot_err_valid(struct cxl_cper_sec_prot_err *prot_err)
  }
  EXPORT_SYMBOL_GPL(cxl_cper_sec_prot_err_valid);
  
-static void cxl_cper_post_prot_err(struct cxl_cper_sec_prot_err *prot_err,
-				   int severity)
+int cxl_cper_setup_prot_err_work_data(struct cxl_cper_prot_err_work_data *wd,
+				      struct cxl_cper_sec_prot_err *prot_err,
+				      int severity)
  {
-	struct cxl_cper_prot_err_work_data wd;
  	u8 *dvsec_start, *cap_start;
  
-	if (cxl_cper_sec_prot_err_valid(prot_err))
-		return;
-
-	guard(spinlock_irqsave)(&cxl_cper_prot_err_work_lock);
-
-	if (!cxl_cper_prot_err_work)
-		return;
-
  	switch (prot_err->agent_type) {
  	case RCD:
  	case DEVICE:
@@ -756,20 +748,40 @@ static void cxl_cper_post_prot_err(struct cxl_cper_sec_prot_err *prot_err,
  	case RP:
  	case DSP:
  	case USP:
-		memcpy(&wd.prot_err, prot_err, sizeof(wd.prot_err));
+		memcpy(&wd->prot_err, prot_err, sizeof(wd->prot_err));
  
  		dvsec_start = (u8 *)(prot_err + 1);
  		cap_start = dvsec_start + prot_err->dvsec_len;
  
-		memcpy(&wd.ras_cap, cap_start, sizeof(wd.ras_cap));
-		wd.severity = cper_severity_to_aer(severity);
+		memcpy(&wd->ras_cap, cap_start, sizeof(wd->ras_cap));
+		wd->severity = cper_severity_to_aer(severity);
  		break;
  	default:
  		pr_err_ratelimited("CXL CPER invalid agent type: %d\n",
  				   prot_err->agent_type);
-		return;
+		return -EINVAL;
  	}
  
+	return 0;
+}
+EXPORT_SYMBOL_GPL(cxl_cper_setup_prot_err_work_data);
+
+static void cxl_cper_post_prot_err(struct cxl_cper_sec_prot_err *prot_err,
+				   int severity)
+{
+	struct cxl_cper_prot_err_work_data wd;
+
+	if (cxl_cper_sec_prot_err_valid(prot_err))
+		return;
+
+	guard(spinlock_irqsave)(&cxl_cper_prot_err_work_lock);
+
+	if (!cxl_cper_prot_err_work)
+		return;
+
+	if (cxl_cper_setup_prot_err_work_data(&wd, prot_err, severity))
+		return;
+
  	if (!kfifo_put(&cxl_cper_prot_err_fifo, wd)) {
  		pr_err_ratelimited("CXL CPER kfifo overflow\n");
  		return;
diff --git a/include/cxl/event.h b/include/cxl/event.h
index 4d7d1036ea9c..94081aec597a 100644
--- a/include/cxl/event.h
+++ b/include/cxl/event.h
@@ -322,12 +322,22 @@ static inline int cxl_cper_prot_err_kfifo_get(struct cxl_cper_prot_err_work_data
  
  #ifdef CONFIG_ACPI_APEI_PCIEAER
  int cxl_cper_sec_prot_err_valid(struct cxl_cper_sec_prot_err *prot_err);
+int cxl_cper_setup_prot_err_work_data(struct cxl_cper_prot_err_work_data *wd,
+				      struct cxl_cper_sec_prot_err *prot_err,
+				      int severity);
  #else
  static inline int
  cxl_cper_sec_prot_err_valid(struct cxl_cper_sec_prot_err *prot_err)
  {
  	return -EOPNOTSUPP;
  }
+static inline int
+cxl_cper_setup_prot_err_work_data(struct cxl_cper_prot_err_work_data *wd,
+				  struct cxl_cper_sec_prot_err *prot_err,
+				  int severity)
+{
+	return -EOPNOTSUPP;
+}
  #endif
  
  #endif /* _LINUX_CXL_EVENT_H */
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>

Thanks
Hanjun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help