Thread (54 messages) 54 messages, 7 authors, 2026-01-16

Re: [PATCH v5 17/34] random: vDSO: remove ifdeffery

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: 2025-11-07 23:37:29
Also in: linux-arm-kernel, linux-kselftest, linux-mips, linux-s390, lkml, loongarch, sparclinux

On Thu, Nov 06, 2025 at 11:02:10AM +0100, Thomas Weißschuh wrote:
-#endif
+	if (IS_ENABLED(CONFIG_VDSO_GETRANDOM))
+		smp_store_release((unsigned long *)&vdso_k_rng_data->generation, next_gen + 1);
+
This is possible because vdso_k_rng_data is now defined in the C source
on all platforms and under all configurations, even if
!CONFIG_VDSO_GETRANDOM means it's null? Whereas before, some config's
headers didn't have this at all, so the #ifdef was necessary?

If so, can you mention this in the commit message?

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help