Re: [PATCH] PCI: pnv_php: Fix potential NULL dereference in slot allocator

----- Original Message -----

From: "Jiri Slaby" <jirislaby@kernel.org>
To: "Timothy Pearson" <tpearson@raptorengineering.com>
Cc: "linuxppc-dev" <redacted>, "linux-kernel" <redacted>, "linux-pci"
[off-list ref], "Madhavan Srinivasan" [off-list ref], "Michael Ellerman" [off-list ref],
"christophe leroy" [off-list ref], "Naveen N Rao" [off-list ref], "Bjorn Helgaas"
[off-list ref], "Shawn Anastasio" [off-list ref]
Sent: Thursday, October 9, 2025 12:54:19 AM
Subject: Re: [PATCH] PCI: pnv_php: Fix potential NULL dereference in slot allocator

On 09. 10. 25, 3:24, Timothy Pearson wrote:

quoted

A highly unlikely NULL dereference in the allocation error handling path was
introduced in 466861909255.  Avoid dereferencing php_slot->bus by using
dev_warn() instead of SLOT_WARN() in the error path.

Fixes: 466861909255 ("PCI: pnv_php: Clean up allocated IRQs on unplug")
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>

LGTM, perhaps also a lnk to the report:
Link:
https://lore.kernel.org/all/304758063.1694752.1757427687463.JavaMail.zimbra@raptorengineeringinc.com/ (local)


Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

thanks,
--
js
suse labs

Just a quick follow up on this to see if we could get it merged?  Thanks!