Thread (43 messages) 43 messages, 9 authors, 2025-12-19

Re: [patch V5 10/12] futex: Convert to get/put_user_inline()

From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: 2025-10-28 14:24:50
Also in: linux-arm-kernel, linux-fsdevel, linux-riscv, linux-s390, lkml

On 2025-10-27 04:44, Thomas Gleixner wrote:
From: Thomas Gleixner <redacted>

Replace the open coded implementation with the new get/put_user_inline()
helpers. This might be replaced by a regular get/put_user(), but that needs
a proper performance evaluation.
I understand that this is aiming to keep the same underlying code,
but I find it surprising that the first user of the "inline" get/put
user puts the burden of the proof on moving this to regular
get/put_user() rather than on using the inlined version.

The comment above the inline API clearly states that performance
numbers are needed to justify the use of inline, not the opposite.

I am concerned that this creates a precedent that may be used by future
users of the inline API to use it without performance numbers
justification.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help