Re: [PATCH v2 1/3] powerpc/xive: Untangle xive from child interrupt controller drivers

From
Nam Cao <hidden>
Date
2025-10-07 05:24:36
Also in
lkml
Reply to
Ritesh Harjani (IBM), 2025-10-07
Hi Ritesh,

Ritesh Harjani (IBM) [off-list ref] writes:
I am facing kernel crash on host when trying to run kvm pseries guest on
powernv host. Looking it a bit more closely, I see that we are missing
conversion of xxx_irq_handler_data()) to xxx_irq_chip_data() at few other
places, including in powerpc KVM code. 
[snip]
Here is the diff which fixed this.. 
[snip]
... However grepping for "handler_data" in arch/powerpc I see there is
atleast one more place where we may still need the fix.. There are few
more places which grep returned - but I am not sure if they all really need
the fix. But I guess VAS should be fixed i.e :

arch/powerpc/platforms/powernv/vas.c:   xd = irq_get_handler_data(vinst->virq);

Would you like to submit an official patch for converting these other places too?
Thanks for the report. I didn't expect struct xive_irq_data to be used
in multiple files while making that patch, sorry about that!

Something like your patch should do the job. However, my gut feeling is
that multiple files shouldn't share a single irq struct this way. Let me
stare at it...

Nam
Thread (10 messages) 10 messages, 4 authors, last reply 2025-10-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help