[PATCH 26/39] binderfs_binder_ctl_create(): kill a bogus check
From: Al Viro <viro@zeniv.linux.org.uk>
Date: 2025-09-20 07:48:07
Also in:
linux-efi, linux-fsdevel, linux-mm, linux-usb, ocfs2-devel
Subsystem:
android drivers, the rest · Maintainers:
Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos, Christian Brauner, Carlos Llamas, Alice Ryhl, Linus Torvalds
It's called once, during binderfs mount, right after allocating root dentry. Checking that it hadn't been already called is only obfuscating things. Looks like that bogosity had been copied from devpts... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- drivers/android/binderfs.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index 41a0f3c26fcf..bb81280a3e9f 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c@@ -395,12 +395,6 @@ static int binderfs_binder_ctl_create(struct super_block *sb) if (!device) return -ENOMEM; - /* If we have already created a binder-control node, return. */ - if (info->control_dentry) { - ret = 0; - goto out; - } - ret = -ENOMEM; inode = new_inode(sb); if (!inode)
--
2.47.3