Thread (16 messages) 16 messages, 6 authors, 2025-09-05

Re: [PATCH v3 4/7] riscv: Stop calling page_address() in free_pages()

From: Alexandre Ghiti <alex@ghiti.fr>
Date: 2025-09-04 12:27:06
Also in: linux-arm-kernel, linux-block, linux-efi, linux-mm, linux-riscv, lkml, virtualization

Hi Vishal,

On 9/3/25 20:59, Vishal Moola (Oracle) wrote:
quoted hunk ↗ jump to hunk
free_pages() should be used when we only have a virtual address. We
should call __free_pages() directly on our page instead.

Signed-off-by: Vishal Moola (Oracle) <redacted>
---
  arch/riscv/mm/init.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
index 15683ae13fa5..1056c11d3251 100644
--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -1624,7 +1624,7 @@ static void __meminit free_pud_table(pud_t *pud_start, p4d_t *p4d)
  	if (PageReserved(page))
  		free_reserved_page(page);
  	else
-		free_pages((unsigned long)page_address(page), 0);
+		__free_pages(page, 0);
  	p4d_clear(p4d);
  }
  
@@ -1646,7 +1646,7 @@ static void __meminit free_vmemmap_storage(struct page *page, size_t size,
  		return;
  	}
  
-	free_pages((unsigned long)page_address(page), order);
+	__free_pages(page, order);
  }
  
  static void __meminit remove_pte_mapping(pte_t *pte_base, unsigned long addr, unsigned long end,

Acked-by: Alexandre Ghiti <redacted>

Thanks,

Alex

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help