Thread (12 messages) 12 messages, 3 authors, 2025-09-09

Re: [PATCH v5 6/7] dt-bindings: soc: fsl: qe: Convert QE GPIO to DT schema

From: Christophe Leroy <hidden>
Date: 2025-09-03 05:20:34
Also in: linux-arm-kernel, linux-devicetree, linux-gpio, lkml

Hi Rob,

Le 02/09/2025 à 23:24, Rob Herring a écrit :
On Mon, Sep 01, 2025 at 02:05:13PM +0200, Christophe Leroy wrote:
quoted
Convert QE QPIO devicetree binding to DT schema.

Signed-off-by: Christophe Leroy <redacted>
---
v5: New
---
quoted
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - fsl,chip-qe-pario-bank
+      - const: fsl,mpc8323-qe-pario-bank
+
snip
quoted
+        compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-pario-bank";
Doesn't match the schema.
Can you be more explicit ? Is it the 'mpc8360' ? It is the 'chip'.


bindings/soc/fsl/cpm_qe/qe/par_io.txt was saying:

   - compatible : should be "fsl,<chip>-qe-pario-bank", 
"fsl,mpc8323-qe-pario-bank".

Which I first translated in yaml as :

   properties:
     compatible:
       items:
         - enum:
           - fsl,<chip>-qe-pario-bank
         - const: fsl,mpc8323-qe-pario-bank

But 'make dt_binding_check' complained about the < > around 'chip' so I 
removed them.

How should it be described ?

Thanks
Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help