Re: [PATCH v3 03/12] cpufreq: intel_pstate: Use scope-based cleanup helper
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2025-09-01 15:17:18
Also in:
dri-devel, imx, intel-gfx, linux-acpi, linux-arm-kernel, linux-omap, linux-pm, lkml
On Mon, Sep 1, 2025 at 10:58 AM Zihuan Zhang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy) annotation for policy references. This reduces the risk of reference counting mistakes and aligns the code with the latest kernel style. No functional change intended. Signed-off-by: Zihuan Zhang <redacted> --- drivers/cpufreq/intel_pstate.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index f366d35c5840..4abc1ef2d2b0 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c@@ -1502,9 +1502,8 @@ static void __intel_pstate_update_max_freq(struct cpufreq_policy *policy, static bool intel_pstate_update_max_freq(struct cpudata *cpudata) { - struct cpufreq_policy *policy __free(put_cpufreq_policy); + struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpudata->cpu); - policy = cpufreq_cpu_get(cpudata->cpu); if (!policy) return false;
The structure of the code is intentional here and there's no reason to change it.