Re: [PATCH v3 5/6] dt-bindings: soc: fsl: qe: Add support of IRQ in QE GPIO

From
Rob Herring <robh@kernel.org>
Date
2025-08-28 13:28:47
Also in
linux-arm-kernel, linux-devicetree, linux-gpio, lkml
Reply to
Christophe Leroy, 2025-08-25
On Mon, Aug 25, 2025 at 2:20 AM Christophe Leroy
[off-list ref] wrote:
In the QE, a few GPIOs are IRQ capable. Similarly to
commit 726bd223105c ("powerpc/8xx: Adding support of IRQ in MPC8xx
GPIO"), add IRQ support to QE GPIO.

Add property 'fsl,qe-gpio-irq-mask' similar to
'fsl,cpm1-gpio-irq-mask' that define which of the GPIOs have IRQs.
Why do you need to know this? The ones that have interrupts will be
referenced by an 'interrupts' property somewhere.
Here is an exemple for port B of mpc8323 which has IRQs for
typo
GPIOs PB7, PB9, PB25 and PB27.

        qe_pio_b: gpio-controller@1418 {
                compatible = "fsl,mpc8323-qe-pario-bank";
                reg = <0x1418 0x18>;
                interrupts = <4 5 6 7>;
                interrupt-parent = <&qepic>;
                gpio-controller;
                #gpio-cells = <2>;
                fsl,qe-gpio-irq-mask = <0x01400050>;
        };
You are missing #interrupt-cells and interrupt-controller properties.

With multiple new properties, this should be converted to schema first.
quoted hunk ↗ jump to hunk
Signed-off-by: Christophe Leroy <redacted>
---
 .../bindings/soc/fsl/cpm_qe/qe/par_io.txt     | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
index 09b1b05fa677..829fe9a3d70c 100644
--- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
+++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
@@ -32,6 +32,15 @@ Required properties:
   "fsl,mpc8323-qe-pario-bank".
 - reg : offset to the register set and its length.
 - gpio-controller : node to identify gpio controllers.
+Optional properties:
+- fsl,qe-gpio-irq-mask : For banks having interrupt capability this item tells
+  which ports have an associated interrupt (ports are listed in the same order
+  as in QE ports registers)
+- interrupts : This property provides the list of interrupt for each GPIO having
+  one as described by the fsl,cpm1-gpio-irq-mask property. There should be as
+  many interrupts as number of ones in the mask property. The first interrupt in
+  the list corresponds to the most significant bit of the mask.
+- interrupt-parent : Parent for the above interrupt property.

 Example:
        qe_pio_a: gpio-controller@1400 {
@@ -42,6 +51,16 @@ Example:
                gpio-controller;
          };

+       qe_pio_b: gpio-controller@1418 {
+               #gpio-cells = <2>;
+               compatible = "fsl,mpc8323-qe-pario-bank";
+               reg = <0x1418 0x18>;
+               interrupts = <4 5 6 7>;
+               fsl,qe-gpio-irq-mask = <0x01400050>;
+               interrupt-parent = <&qepic>;
+               gpio-controller;
+         };
+
        qe_pio_e: gpio-controller@1460 {
                #gpio-cells = <2>;
                compatible = "fsl,mpc8360-qe-pario-bank",
--
2.49.0
  
Thread (21 messages) 21 messages, 4 authors, last reply 2025-08-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help