Re: [PATCH RFC 05/29] mm/balloon_compaction: make PageOffline sticky
From: Zi Yan <ziy@nvidia.com>
Date: 2025-06-18 18:51:06
Also in:
linux-doc, linux-fsdevel, linux-mm, lkml, virtualization
On 18 Jun 2025, at 13:39, David Hildenbrand wrote:
Let the buddy handle clearing the type.
The below might be more precise? Since page type is cleared before the page reaches buddy code. Let the free page routine handle clearing the type.
quoted hunk ↗ jump to hunk
Signed-off-by: David Hildenbrand <redacted> --- include/linux/balloon_compaction.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index b9f19da37b089..bfc6e50bd004b 100644 --- a/include/linux/balloon_compaction.h +++ b/include/linux/balloon_compaction.h@@ -140,7 +140,7 @@ static inline void balloon_page_finalize(struct page *page) __ClearPageMovable(page); set_page_private(page, 0); } - __ClearPageOffline(page); + /* PageOffline is sticky until the page is freed to the buddy. */ } /*-- 2.49.0
Acked-by: Zi Yan <ziy@nvidia.com> Best Regards, Yan, Zi