Thread (28 messages) 28 messages, 5 authors, 2025-06-14

Re: [PATCH v2 09/12] lib/crc/s390: migrate s390-optimized CRC code into lib/crc/

From: Alexander Gordeev <agordeev@linux.ibm.com>
Date: 2025-06-14 13:24:38
Also in: linux-arch, linux-arm-kernel, linux-crypto, linux-mips, linux-riscv, linux-s390, lkml, loongarch, sparclinux

On Fri, Jun 13, 2025 at 10:11:43AM -0700, Eric Biggers wrote:
quoted
Hi Eric,

With this series I am getting on s390:

alg: hash: skipping comparison tests for crc32c-s390 because crc32c-generic is unavailable

Thanks!
I think that's actually from "crypto/crc32c: register only one shash_alg"
(https://lore.kernel.org/linux-crypto/20250601224441.778374-3-ebiggers@kernel.org/ (local)),
not the patch you replied to.

Those self-test warnings are expected.  But I guess they are going to confuse
people, so we should do something to make them go away.

I think we should do what I've proposed for SHA-512: stop worrying about setting
the cra_driver_name to something meaningful (which has never really worked
anyway), instead just use *-lib, and update crypto/testmgr.c accordingly.

I'll send out patches that do that.
Thanks, Eric!
Please, ignore my other email - I though I did not send this one.
- Eric
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help