Thread (7 messages) 7 messages, 3 authors, 2025-05-12

Re: [PATCH 0/4] crypto: lib/chacha - improve type safety

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2025-05-12 05:46:07
Also in: linux-arm-kernel, linux-bcachefs, linux-crypto, linux-mips, linux-riscv, linux-s390, lkml

Eric Biggers [off-list ref] wrote:
This series can also be retrieved from:

   git fetch https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git chacha-prototypes-v1

This series improves type safety and clarity in the ChaCha functions by
strongly typing the state array and adding explicit array bounds for
other fixed-length arrays.  No functional changes.

Eric Biggers (4):
 crypto: lib/chacha - strongly type the ChaCha state
 crypto: lib/chacha - use struct assignment to copy state
 crypto: lib/chacha - add strongly-typed state zeroization
 crypto: lib/chacha - add array bounds to function prototypes

arch/arm/lib/crypto/chacha-glue.c             | 34 ++++----
arch/arm/lib/crypto/chacha-scalar-core.S      |  5 +-
arch/arm64/lib/crypto/chacha-neon-glue.c      | 27 ++++---
arch/mips/lib/crypto/chacha-glue.c            |  6 +-
arch/powerpc/lib/crypto/chacha-p10-glue.c     | 17 ++--
arch/powerpc/lib/crypto/chacha-p10le-8x.S     |  6 +-
arch/riscv/lib/crypto/chacha-riscv64-glue.c   |  9 ++-
arch/riscv/lib/crypto/chacha-riscv64-zvkb.S   | 10 +--
arch/s390/lib/crypto/chacha-glue.c            | 13 +--
arch/x86/lib/crypto/chacha_glue.c             | 62 ++++++++------
crypto/chacha.c                               | 20 ++---
drivers/char/random.c                         | 41 +++++-----
fs/bcachefs/checksum.c                        | 18 ++---
include/crypto/chacha.h                       | 80 ++++++++++++-------
lib/crypto/chacha.c                           | 40 +++++-----
lib/crypto/chacha20poly1305-selftest.c        |  8 +-
lib/crypto/chacha20poly1305.c                 | 53 ++++++------
lib/crypto/libchacha.c                        |  2 +-
.../crypto/chacha20-s390/test-cipher.c        | 10 +--
19 files changed, 253 insertions(+), 208 deletions(-)


base-commit: 64745a9ca890ed60d78162ec511e1983e1946d73
All applied.  Thanks.
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help