Thread (1 message) 1 message, 1 author, 2025-05-05

Re: [PATCH bpf-next v3 02/11] bpf: Move insn if/else into do_check_insn()

From: Luis Gerhorst <hidden>
Date: 2025-05-05 18:32:06
Also in: bpf, linux-arm-kernel, linux-kselftest, lkml

Eduard Zingerman [off-list ref] writes:
On Thu, 2025-05-01 at 09:35 +0200, Luis Gerhorst wrote:
quoted
+		dst_reg_type = cur_regs(env)[insn->dst_reg].type;
Implicitly relying on `insn == &env->prog->insnsi[env->cur_idx]`
is weird. Still think that `insn` parameter should be dropped and
computed inside this function instead.
quoted
+				return -EINVAL;
+			}
+process_bpf_exit_full:
Nit: since we are refactoring I'd extract this as a function instead of goto.
Both done, thanks again for the review and testing!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help