Hi





On 4/30/25 18:40, Srikar Dronamraju wrote:

* Shrikanth Hegde [off-list ref] [2025-03-14 17:15:02]:

Hi Srikar.

quoted

use guard(mutex) for scope based resource management of mutex
This would make the code simpler and easier to maintain.

More details on lock guards can be found at
https://lore.kernel.org/all/20230612093537.614161713@infradead.org/T/#u (local)

Signed-off-by: Shrikanth Hegde <redacted>
---
  arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c | 8 +-------
  1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c b/arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c
index ce6c739c51e5..bbfc7c39b957 100644
--- a/arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c
+++ b/arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c

@@ -75,7 +75,7 @@ static ssize_t fsl_timer_wakeup_store(struct device *dev,
  	if (kstrtoll(buf, 0, &interval))
  		return -EINVAL;
  
-	mutex_lock(&sysfs_lock);
+	guard(mutex)(&sysfs_lock);
  
  	if (fsl_wakeup->timer) {
  		disable_irq_wake(fsl_wakeup->timer->irq);

@@ -84,14 +84,12 @@ static ssize_t fsl_timer_wakeup_store(struct device *dev,
  	}
  
  	if (!interval) {
-		mutex_unlock(&sysfs_lock);
  		return count;
  	}

Nit: Here and the next change, due to the current change, there is no need
for curly braces.

Ok. will fix it next version.

Other than this nit looks good to me.

Reviewed-by: Srikar Dronamraju <redacted>

Thanks for the reviews.