Re: [v3 PATCH 00/13] Architecture-optimized SHA-256 library API
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2025-04-30 02:44:05
Also in:
linux-arch, linux-arm-kernel, linux-crypto, linux-mips, linux-riscv, linux-s390, lkml, sparclinux
On Tue, Apr 29, 2025 at 07:38:49PM -0700, Eric Biggers wrote:
Nothing requires that the export formats be consistent, but also the fact that padlock-sha uses a weird format in the first place is an artificial problem that you introduced just a couple weeks ago. And even if we *must* use the same format as padlock-sha, that can be done by using your crypto_sha256_export_lib and crypto_sha256_import_lib, without all your other changes.
That was just the reason of why I can't take your first patch as is and then add my changes as incremental patches. I do still want to bypass the partial block handling in lib/crypto. But alright I will do it like this: Patch 1 is just your existing patch + my export/import functions. Then I will add the rest of my changes as incremental patches. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt