Re: [PATCH v7 7/7] powerpc/pseries: Add a char driver for physical-attestation RTAS

Hi Haren,

kernel test robot noticed the following build warnings:

[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v6.14-rc6]
[cannot apply to next-20250307]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Haren-Myneni/powerpc-pseries-Define-common-functions-for-RTAS-sequence-calls/20250310-054319
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20250309213916.762116-8-haren%40linux.ibm.com
patch subject: [PATCH v7 7/7] powerpc/pseries: Add a char driver for physical-attestation RTAS
config: powerpc64-randconfig-r072-20250311 (https://download.01.org/0day-ci/archive/20250311/202503111945.ijp4Nbkl-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project e15545cad8297ec7555f26e5ae74a9f0511203e7)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250311/202503111945.ijp4Nbkl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202503111945.ijp4Nbkl-lkp@intel.com/ (local)

All warnings (new ones prefixed by >>):

quoted

arch/powerpc/platforms/pseries/papr-phy-attest.c:137: warning: Function parameter or struct member 'seq' not described in 'phy_attest_sequence_begin'

vim +137 arch/powerpc/platforms/pseries/papr-phy-attest.c

   121	
   122	/*
   123	 * Internal physical-attestation sequence APIs. A physical-attestation
   124	 * sequence is a series of calls to get ibm,physical-attestation
   125	 * for a given attestation command. The sequence ends when an error
   126	 * is encountered or all data for the attestation command has been
   127	 * returned.
   128	 */
   129	
   130	/**
   131	 * phy_attest_sequence_begin() - Begin a response data for attestation
   132	 * command retrieval sequence.
   133	 *
   134	 * Context: May sleep.
   135	 */
   136	static void phy_attest_sequence_begin(struct papr_rtas_sequence *seq)
 > 137	{
   138		struct rtas_phy_attest_params *param;
   139	
   140		/*
   141		 * We could allocate the work area before acquiring the
   142		 * function lock, but that would allow concurrent requests to
   143		 * exhaust the limited work area pool for no benefit. So
   144		 * allocate the work area under the lock.
   145		 */
   146		mutex_lock(&rtas_ibm_physical_attestation_lock);
   147		param =  (struct rtas_phy_attest_params *)seq->params;
   148		param->work_area = rtas_work_area_alloc(SZ_4K);
   149		memcpy(rtas_work_area_raw_buf(param->work_area), &param->cmd,
   150				param->cmd_len);
   151		param->sequence = 1;
   152		param->status = 0;
   153	}
   154	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki