Re: [PATCH bpf-next 09/11] bpf: Return PTR_ERR from push_stack()
From: Eduard Zingerman <eddyz87@gmail.com>
Date: 2025-03-17 09:19:14
Also in:
bpf, linux-arm-kernel, linux-kselftest, lkml
On Thu, 2025-03-13 at 18:41 +0100, Luis Gerhorst wrote: [...]
quoted hunk ↗ jump to hunk
@@ -2011,8 +2011,10 @@ static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env, int err; elem = kzalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL); - if (!elem) - goto err; + if (!elem) { + err = -ENOMEM; + goto unrecoverable_err; + }
Could you please point me to a location, where exact error code returned by updated push_stack() matters? I checked push_stack() callgraph (in the attachment), but can't find anything.
quoted hunk ↗ jump to hunk
elem->insn_idx = insn_idx; elem->prev_insn_idx = prev_insn_idx;@@ -2022,12 +2024,19 @@ static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
[...]
Attachments
- push_stack.dot [text/vnd.graphviz] 1706 bytes · preview