[PATCH 2/2] powerpc: gpio_mdio: Use devm_of_mdiobus_register()
From: Christophe JAILLET <hidden>
Date: 2025-03-02 14:59:42
Also in:
kernel-janitors, lkml
Subsystem:
linux for powerpc (32-bit and 64-bit), the rest · Maintainers:
Madhavan Srinivasan, Michael Ellerman, Linus Torvalds
Use devm_of_mdiobus_register() in order to remove the now empty .remove() function. Doing so dev_set_drvdata() is now also unneeded. Remove it as well. Signed-off-by: Christophe JAILLET <redacted> --- This patch is compile tested only. --- arch/powerpc/platforms/pasemi/gpio_mdio.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/arch/powerpc/platforms/pasemi/gpio_mdio.c b/arch/powerpc/platforms/pasemi/gpio_mdio.c
index 2c54f5f063b7..6712ccb84c0a 100644
--- a/arch/powerpc/platforms/pasemi/gpio_mdio.c
+++ b/arch/powerpc/platforms/pasemi/gpio_mdio.c@@ -234,10 +234,8 @@ static int gpio_mdio_probe(struct platform_device *ofdev) priv->mdio_pin = *prop; new_bus->parent = dev; - dev_set_drvdata(dev, new_bus); - - err = of_mdiobus_register(new_bus, np); + err = devm_of_mdiobus_register(dev, new_bus, np); if (err != 0) { pr_err("%s: Cannot register as MDIO bus, err %d\n", new_bus->name, err);
@@ -247,16 +245,6 @@ static int gpio_mdio_probe(struct platform_device *ofdev) return 0; } - -static void gpio_mdio_remove(struct platform_device *dev) -{ - struct mii_bus *bus = dev_get_drvdata(&dev->dev); - - mdiobus_unregister(bus); - - dev_set_drvdata(&dev->dev, NULL); -} - static const struct of_device_id gpio_mdio_match[] = { {
@@ -269,7 +257,6 @@ MODULE_DEVICE_TABLE(of, gpio_mdio_match); static struct platform_driver gpio_mdio_driver = { .probe = gpio_mdio_probe, - .remove = gpio_mdio_remove, .driver = { .name = "gpio-mdio-bitbang", .of_match_table = gpio_mdio_match,
--
2.48.1