On 2/24/25 17:31, Christophe Leroy wrote:

Le 17/02/2025 à 05:22, Anshuman Khandual a écrit :

quoted

Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP.
But generic ptdump gets enabled via PTDUMP_CORE. These configs combination
is confusing as they sound very similar and does not differentiate between
platform's feature subscription and feature enablement for ptdump. Rename
the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve
readability.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Paul Walmsley <redacted>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Thomas Gleixner <redacted>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: kvmarm@lists.linux.dev
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-riscv@lists.infradead.org
Cc: linux-s390@vger.kernel.org
Cc: linux-mm@kvack.org
Signed-off-by: Anshuman Khandual <redacted>
---

diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index 7612c52e9b1e..5aef2aa4103c 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig

@@ -43,6 +43,7 @@ config RISCV

      select ARCH_HAS_PMEM_API
      select ARCH_HAS_PREEMPT_LAZY
      select ARCH_HAS_PREPARE_SYNC_CORE_CMD
+    select ARCH_HAS_PTDUMP

Is it OK to drop the 'if MMU' from below ?

Sure, will add it back.

quoted

      select ARCH_HAS_PTE_DEVMAP if 64BIT && MMU
      select ARCH_HAS_PTE_SPECIAL
      select ARCH_HAS_SET_DIRECT_MAP if MMU

@@ -112,7 +113,6 @@ config RISCV

      select GENERIC_IRQ_SHOW_LEVEL
      select GENERIC_LIB_DEVMEM_IS_ALLOWED
      select GENERIC_PCI_IOMAP
-    select GENERIC_PTDUMP if MMU
      select GENERIC_SCHED_CLOCK
      select GENERIC_SMP_IDLE_THREAD
      select GENERIC_TIME_VSYSCALL if MMU && 64BIT