Re: [PATCH 3/3] bitmap: break kunit into test cases

On Sat, Feb 8, 2025 at 4:07 AM David Gow [off-list ref] wrote:

On Sat, 8 Feb 2025 at 04:14, Tamir Duberstein [off-list ref] wrote:

quoted

Move some tests into `bitmap_test_cases` and parameterize
`test_bitmap_print_buf`. This gives us nicer output in the event of a
failure.

Signed-off-by: Tamir Duberstein <redacted>
---

I very much like this cleanup: the static global 'kunittest' was annoying me.

I think there's an argument to get rid of tc_err() entirely, and just
use KUNIT_FAIL directly, but I'm happy either way: it is a lot of
churn.

I'm happy to do that. Pulling on that thread ended up producing a nice
cleanup. There's no way to add a patch to the series without sending
it all again, is there?

Reviewed-by: David Gow <redacted>

Thanks for the review!