Thread (51 messages) 51 messages, 3 authors, 2025-02-17

Re: [kvm-unit-tests PATCH v2 09/18] scripts/runtime: Skip test when kvmtool and $accel is not KVM

From: Andrew Jones <hidden>
Date: 2025-01-21 16:30:53
Also in: kvm, kvm-riscv, kvmarm, linux-s390

On Mon, Jan 20, 2025 at 04:43:07PM +0000, Alexandru Elisei wrote:
quoted hunk ↗ jump to hunk
kvmtool, unlike qemu, cannot emulate a different architecture than the
host's, and as a result the only $accel parameter it can support is 'kvm'.

Signed-off-by: Alexandru Elisei <redacted>
---
 scripts/runtime.bash | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/scripts/runtime.bash b/scripts/runtime.bash
index ee8a188b22ce..55d58eef9c7c 100644
--- a/scripts/runtime.bash
+++ b/scripts/runtime.bash
@@ -153,6 +153,11 @@ function run()
         accel="$ACCEL"
     fi
 
+    if [[ "$TARGET" = kvmtool ]] && [[ -n "$accel" ]] && [[ "$accel" != "kvm" ]]; then
+        print_result "SKIP" $testname "" "kvmtool does not support $accel"
+        return 2
+    fi
+
     # check a file for a particular value before running a test
     # the check line can contain multiple files to check separated by a space
     # but each check parameter needs to be of the form <path>=<value>
-- 
2.47.1
Reviewed-by: Andrew Jones <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help