Re: [PATCH 00/34] address all -Wunused-const warnings
From: Andy Shevchenko <hidden>
Date: 2025-01-27 13:25:29
Also in:
alsa-devel, dmaengine, dri-devel, linux-arm-msm, linux-clk, linux-crypto, linux-efi, linux-fbdev, linux-fpga, linux-hardening, linux-i2c, linux-ide, linux-iio, linux-input, linux-integrity, linux-iommu, linux-kbuild, linux-leds, linux-nfs, linux-omap, linux-pm, linux-rockchip, linux-rtc, linux-samsung-soc, linux-scsi, linux-serial, linux-sound, linux-spi, linux-staging, linux-trace-kernel, linux-usb, linux-wireless, lkml, netdev
On Wed, Apr 03, 2024 at 10:06:18AM +0200, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de>
Compilers traditionally warn for unused 'static' variables, but not
if they are constant. The reason here is a custom for C++ programmers
to define named constants as 'static const' variables in header files
instead of using macros or enums.
In W=1 builds, we get warnings only static const variables in C
files, but not in headers, which is a good compromise, but this still
produces warning output in at least 30 files. These warnings are
almost all harmless, but also trivial to fix, and there is no
good reason to warn only about the non-const variables being unused.
I've gone through all the files that I found using randconfig and
allmodconfig builds and created patches to avoid these warnings,
with the goal of retaining a clean build once the option is enabled
by default.
Unfortunately, there is one fairly large patch ("drivers: remove
incorrect of_match_ptr/ACPI_PTR annotations") that touches
34 individual drivers that all need the same one-line change.
If necessary, I can split it up by driver or by subsystem,
but at least for reviewing I would keep it as one piece for
the moment.
Please merge the individual patches through subsystem trees.
I expect that some of these will have to go through multiple
revisions before they are picked up, so anything that gets
applied early saves me from resending.
Arnd, can you refresh this one? It seems some misses still...
I have got 3+ 0-day reports against one of the mux drivers.
https://lore.kernel.org/all/?q=adg792a.c
--
With Best Regards,
Andy Shevchenko