Thread (54 messages) 54 messages, 6 authors, 2025-01-07

Re: [PATCH v4 13/15] mm: pgtable: introduce generic __tlb_remove_table()

From: Qi Zheng <hidden>
Date: 2025-01-07 12:34:41
Also in: linux-arch, linux-arm-kernel, linux-m68k, linux-mips, linux-mm, linux-riscv, linux-s390, linux-sh, linux-um, lkml, loongarch, sparclinux


On 2025/1/7 20:32, Andreas Larsson wrote:
On 2024-12-30 10:07, Qi Zheng wrote:
quoted
diff --git a/arch/sparc/include/asm/tlb_32.h b/arch/sparc/include/asm/tlb_32.h
index 5cd28a8793e39..910254867dfbd 100644
--- a/arch/sparc/include/asm/tlb_32.h
+++ b/arch/sparc/include/asm/tlb_32.h
@@ -2,6 +2,7 @@
  #ifndef _SPARC_TLB_H
  #define _SPARC_TLB_H
  
+#define __HAVE_ARCH_TLB_REMOVE_TABLE
sparc32 does not select MMU_GATHER_TABLE_FREE, and therefore does not
have (nor need) __tlb_remove_table, so this define should not be added.
Got it. Will remove it in v5.
quoted
  #include <asm-generic/tlb.h>
  
  #endif /* _SPARC_TLB_H */
diff --git a/arch/sparc/include/asm/tlb_64.h b/arch/sparc/include/asm/tlb_64.h
index 3037187482db7..1a6e694418e39 100644
--- a/arch/sparc/include/asm/tlb_64.h
+++ b/arch/sparc/include/asm/tlb_64.h
@@ -33,6 +33,7 @@ void flush_tlb_pending(void);
  #define tlb_needs_table_invalidate()	(false)
  #endif
  
+#define __HAVE_ARCH_TLB_REMOVE_TABLE
  #include <asm-generic/tlb.h>
  
  #endif /* _SPARC64_TLB_H */
LGTM.


With the removal of the define for sparc32 in v5:

Acked-by: Andreas Larsson <andreas@gaisler.com> # sparc
Thanks!
Thanks,
Andreas
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help