Thread (4 messages) 4 messages, 2 authors, 2025-01-03

Re: [PATCH] PCI/AER:Add error message when unable to handle additional devices

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Date: 2025-01-03 11:17:36
Also in: linux-pci, lkml

On Fri, 27 Dec 2024 12:49:10 +0530
Atharva Tiwari [off-list ref] wrote:
Log an error message in `find_device_iter'
when the system cannot handle more error devices.
Needs a statement of 'why'

Jonathan
quoted hunk ↗ jump to hunk
Signed-off-by: Atharva Tiwari <redacted>
---
 drivers/pci/pcie/aer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index 34ce9f834d0c..04743617202e 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -886,7 +886,7 @@ static int find_device_iter(struct pci_dev *dev, void *data)
 		/* List this device */
 		if (add_error_device(e_info, dev)) {
 			/* We cannot handle more... Stop iteration */
-			/* TODO: Should print error message here? */
+			pr_err("PCI: Unable to handle additional error devices\n");
 			return 1;
 		}
 
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help