Re: [PATCH] ps3disk: Do not use dev->bounce_size before it is set

From
Christoph Hellwig <hch@lst.de>
Date
2025-01-03 08:56:57
Also in
linux-block, lkml
Reply to
Geert Uytterhoeven, 2025-01-03
On Fri, Jan 03, 2025 at 09:51:25AM +0100, Geert Uytterhoeven wrote:
dev->bounce_size is only initialized after it is used to set the queue
limits.  Fix this by using BOUNCE_SIZE instead.

Fixes: a7f18b74dbe17162 ("ps3disk: pass queue_limits to blk_mq_alloc_disk")
Reported-by: Philipp Hortmann <redacted>
Closes: https://lore.kernel.org/39256db9-3d73-4e86-a49b-300dfd670212@gmail.com (local)
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

But looking at the report it seems like no one cares about ps3 upstream,
and in fact the only person caring at all rather rants on youtube than
helping upstream, so maybe we should just remove the ps3 support entirely?
Thread (4 messages) 4 messages, 4 authors, last reply 2025-01-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help