Thread (12 messages) 12 messages, 3 authors, 2025-11-24

Re: [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header

From: Madhavan Srinivasan <maddy@linux.ibm.com>
Date: 2024-12-16 02:43:06
Also in: lkml


On 12/13/24 11:58 AM, Christophe Leroy wrote:

Le 12/12/2024 à 17:24, Andy Shevchenko a écrit :
quoted
On Mon, Nov 18, 2024 at 03:10:09PM +0100, Christophe Leroy wrote:
quoted
Le 18/11/2024 à 13:31, Andy Shevchenko a écrit :
quoted
Remove legacy-of-mm-gpiochip.h header file. The above mentioned
file provides an OF API that's deprecated. There is no agnostic
alternatives to it and we have to open code the logic which was
hidden behind of_mm_gpiochip_add_data(). Note, most of the GPIO
drivers are using their own labeling schemas and resource retrieval
that only a few may gain of the code deduplication, so whenever
alternative is appear we can move drivers again to use that one.

As a side effect this change fixes a potential memory leak on
an error path, if of_mm_gpiochip_add_data() fails.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Christophe Leroy <redacted>
Thanks, what's next?
Yes, will take this via powerpc tree

Maddy
Next step is that Michael or Madhavan apply it I guess ?

Christophe


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help