Re: [PATCH] tty: hvc: Fix incorrect formatted output

From
Jiri Slaby <jirislaby@kernel.org>
Date
2024-11-07 07:47:06
Also in
linux-serial, lkml
Reply to
liujing, 2024-11-07
On 07. 11. 24, 8:33, liujing wrote:
quoted hunk ↗ jump to hunk
The termno parameter is defined as an unsigned int
in hvc_opal_probe(), So the output format should be %u instead of %d.

Signed-off-by: liujing <redacted>

---
v1 -> V2: Modified the description of commit.
diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
index 095c33ad10f8..1d2e7f2ce088 100644
--- a/drivers/tty/hvc/hvc_opal.c
+++ b/drivers/tty/hvc/hvc_opal.c
@@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device *dev)
  		/* Instanciate now to establish a mapping index==vtermno */
  		hvc_instantiate(termno, termno, ops);
  	} else {
-		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%d\n",
+		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%u\n",
Please re-read my _whole_ previous e-mail.

-- 
js
suse labs
Thread (3 messages) 3 messages, 2 authors, last reply 2024-11-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help