Re: [PATCH] powerpc: Add __must_check to set_memory_...()
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2024-11-06 12:47:55
Also in:
linux-hardening, lkml
Christophe Leroy [off-list ref] writes:
Hi Michael, Le 07/09/2024 à 17:40, Christophe Leroy a écrit :quoted
After the following powerpc commits, all calls to set_memory_...() functions check returned value. - Commit 8f17bd2f4196 ("powerpc: Handle error in mark_rodata_ro() and mark_initmem_nx()") - Commit f7f18e30b468 ("powerpc/kprobes: Handle error returned by set_memory_rox()") - Commit 009cf11d4aab ("powerpc: Don't ignore errors from set_memory_{n}p() in __kernel_map_pages()") - Commit 9cbacb834b4a ("powerpc: Don't ignore errors from set_memory_{n}p() in __kernel_map_pages()") - Commit 78cb0945f714 ("powerpc: Handle error in mark_rodata_ro() and mark_initmem_nx()") All calls in core parts of the kernel also always check returned value, can be looked at with following query: $ git grep -w -e set_memory_ro -e set_memory_rw -e set_memory_x -e set_memory_nx -e set_memory_rox `find . -maxdepth 1 -type d | grep -v arch | grep /` It is now possible to flag those functions with __must_check to make sure no new unchecked call it added. Link: https://github.com/KSPP/linux/issues/7 Signed-off-by: Christophe Leroy <redacted>Do you plan to take this patch anytime soon ? The generic part of the same was already applied in previous cycle, see https://github.com/torvalds/linux/commit/82ce8e2f31a1eb05b1527c3d807bea40031df913
I was waiting for the generic part to land, sorry I missed it. Will put this in next now. cheers