Thread (12 messages) flat view 12 messages, 5 authors, 2024-11-05

RE: [PATCH net-next 0/3] Fix sparse warnings in dpaa_eth driver

From: Madalin Bucur (OSS) <hidden>
Date: 2024-10-30 13:39:20
Also in: linux-arm-kernel, lkml, netdev

-----Original Message-----
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Sent: Tuesday, October 29, 2024 6:43 PM
To: netdev@vger.kernel.org
Cc: David S. Miller <davem@davemloft.net>; Eric Dumazet
[off-list ref]; Jakub Kicinski [off-list ref]; Paolo Abeni
[off-list ref]; Breno Leitao [off-list ref]; Madalin Bucur
[off-list ref]; Ioana Ciornei [off-list ref]; Radu-
Andrei Bulie [off-list ref]; Christophe Leroy
[off-list ref]; Sean Anderson [off-list ref];
linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-arm-
kernel@lists.infradead.org
Subject: [PATCH net-next 0/3] Fix sparse warnings in dpaa_eth driver

This is a follow-up of the discussion at:
https://lore.kernel.org/oe-kbuild-all/20241028-sticky-refined-lionfish-
b06c0c@leitao/
where I said I would take care of the sparse warnings uncovered by
Breno's COMPILE_TEST change for the dpaa_eth driver.

There was one warning that I decided to treat as an actual bug:
https://lore.kernel.org/netdev/20241029163105.44135-1-
vladimir.oltean@nxp.com/
and what remains here are those warnings which I consider harmless.

I would like Christophe to ack the entire series to be taken through
netdev. I find it weird that the qbman driver, whose major API consumer
is netdev, is maintained by a different group. In this case, the buggy
qm_sg_entry_get_off() function is defined in qbman but exclusively
called in netdev.

Vladimir Oltean (3):
  soc: fsl_qbman: use be16_to_cpu() in qm_sg_entry_get_off()
  net: dpaa_eth: add assertions about SGT entry offsets in
    sg_fd_to_skb()
  net: dpaa_eth: extract hash using __be32 pointer in rx_default_dqrr()

 .../net/ethernet/freescale/dpaa/dpaa_eth.c    | 26 ++++++++++++-------
 include/soc/fsl/qman.h                        |  2 +-
 2 files changed, 17 insertions(+), 11 deletions(-)

--
2.34.1
For the series,

Acked-by: Madalin Bucur <redacted>

Thank you!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help