Thread (23 messages) 23 messages, 7 authors, 2024-10-08

Re: [PATCH v8 01/14] Consolidate IO memcpy/memset into iomap_copy.c

From: Christoph Hellwig <hch@infradead.org>
Date: 2024-10-08 09:32:24
Also in: linux-alpha, linux-arch, linux-arm-msm, linux-m68k, linux-s390, linux-sh, linux-sound, linux-um, lkml, loongarch

On Tue, Oct 08, 2024 at 09:27:20AM +0000, Arnd Bergmann wrote:
quoted
 #endif /* CONFIG_TRACE_MMIO_ACCESS */

+extern void memcpy_fromio(void *to, const volatile void __iomem *from,
+			  size_t count);
+extern void memcpy_toio(volatile void __iomem *to, const void *from,
+			size_t count);
+extern void memset_io(volatile void __iomem *dst, int c, size_t count);
+
I think having this globally visible is the reason you are running
into the mismatched prototypes.
Yes, especially as architectures sometimes actually implement this
as macro or inline function.

Please also drop the pointless externs while you're at it.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help