Re: [PATCH 2/2] powerpc/vdso: Implement __arch_get_vdso_rng_data()

On Fri, Oct 04, 2024 at 04:03:34PM +0200, Jason A. Donenfeld wrote:

On Fri, Oct 04, 2024 at 08:52:40PM +1000, Michael Ellerman wrote:

quoted

On October 4, 2024 2:33:54 AM GMT+10:00, "Jason A. Donenfeld" [off-list ref] wrote:

quoted

Hey Christophe, Michael,

This series actually looks pretty okay to me. I realize ThomasW is
working on more generic cleanups that might obliterate the need for
this, and that may or may not wind up in 6.13. But, I was thinking, this
seems like a good correct thing to do, and to do it now for 6.12, maybe
as a fix through the powerpc tree. Then ThomasW can base his work atop
this, which might wind up including the nice lr optimizations you've
made. And then also if ThomasW's work doesn't land or gets reverted or
whatever, at least we'll have this in tree for 6.12.

Michael - what do you think of that? Worth taking these two patches into
your fixes?

I agree the series looks good. But they're not fixes by my reading, so I'd be inclined to put them in next for v6.13?

They're "close enough" to fixes. The get_realdatapage stuff is super
wonky and weird and it's quite good Christophe has gotten rid of it.
Returning NULL from the generic accesor function never really sat right
and looks buggy even if it does work. But more to the point, given the
other scheduled churn for 6.13, it's going to be a tree-clashing
nightmare to get this in later. And this Sunday is rc2 only, so why not.

Bumping to top of the box.

Jason