Re: [PATCH 1/1] crypto: Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2024-09-13 03:00:17
Also in:
linux-crypto, lkml
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2024-09-13 03:00:17
Also in:
linux-crypto, lkml
Danny Tsen [off-list ref] writes:
This patch is to fix an issue when simd is not usable that data mismatch may occur over ipsec tunnel. The fix is to register algs as SIMD modules so that the algorithm is excecuted when SIMD instructions is usable. A new module rfc4106(gcm(aes)) is also added. Re-write AES/GCM assembly codes with smaller footprints and small performance gain. This patch has been tested with the kernel crypto module tcrypt.ko and has passed the selftest. The patch is also tested with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled. Signed-off-by: Danny Tsen <redacted> --- arch/powerpc/crypto/Kconfig | 1 + arch/powerpc/crypto/aes-gcm-p10-glue.c | 141 +- arch/powerpc/crypto/aes-gcm-p10.S | 2421 +++++++++++------------- 3 files changed, 1187 insertions(+), 1376 deletions(-)
As this is a bug fix it should have a Fixes: tag, and probably a stable Cc as well. But that diffstat is really large for a bug fix. Is there no way to fix the issue in a smaller patch? Even if that is just disabling the feature until it can be fixed in subsequent commits? cheers