Re: [PATCH] selftests: vDSO: Also test counter in vdso_test_chacha

From
Jason A. Donenfeld <Jason@zx2c4.com>
Date
2024-09-02 01:25:15
Also in
linux-kselftest, lkml
Reply to
Jason A. Donenfeld, 2024-09-01
On Sun, Sep 01, 2024 at 08:08:13PM +0200, Jason A. Donenfeld wrote:
quoted
+	reference_chacha20_blocks(output1, key, counter1, BLOCKS);
+	__arch_chacha20_blocks_nostack(output2, key, counter2, BLOCKS);
+	if (memcmp(output1, output2, sizeof(output1)) ||
+	    memcmp(counter2, counter2, sizeof(counter1)))
+		return KSFT_FAIL;
+
+	reference_chacha20_blocks(output1, key, counter1, BLOCKS);
+	__arch_chacha20_blocks_nostack(output2, key, counter2, BLOCKS);
+	if (memcmp(output1, output2, sizeof(output1)) ||
+	    memcmp(counter2, counter2, sizeof(counter1)))
+		return KSFT_FAIL;
+
Why repeat these two stanzas? 
Ah, from your commit message:

"The first test verifies that the function properly writes back the
upper word, the second test verifies that the function properly reads
back the upper word."

Thread (4 messages) 4 messages, 2 authors, last reply 2024-09-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help