Re: [PATCH v3 4/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC32

From
Christophe Leroy <hidden>
Date
2024-08-30 16:42:58
Also in
linux-fsdevel, linux-kselftest, linux-mm, linux-trace-kernel, lkml, llvm
Reply to
Jason A. Donenfeld, 2024-08-30

Le 30/08/2024 à 18:14, Jason A. Donenfeld a écrit :
On Fri, Aug 30, 2024 at 05:57:08PM +0200, Christophe Leroy wrote:
quoted
+ *	r5: 8-byte counter input/output (saved on stack)
+ *
+ *	r14-r15: counter
+ */
+SYM_FUNC_START(__arch_chacha20_blocks_nostack)
+	stwu	r1, -96(r1)
+	stw	r5, 20(r1)
+	stmw	r14, 24(r1)
+	li	r31, 4
+	LWZX_LE	r14, 0, r5
+	LWZX_LE	r15, r31, r5
Why swap endian on the counter?
Unlike the keys, the counter is passed to the function as an u8*, not as a u64*, so I thought it was raw data in little endian order, same as when using Sodium. Is it wrong ?

Christophe
Thread (12 messages) 12 messages, 3 authors, last reply 2024-09-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help