Thread (77 messages) 77 messages, 9 authors, 2024-10-17

Re: [PATCH v5 16/30] arm64: handle PKEY/POE faults

From: Mark Brown <broonie@kernel.org>
Date: 2024-08-29 17:55:16
Also in: kvmarm, linux-arm-kernel, linux-fsdevel, linux-kselftest, linux-mm

On Thu, Aug 22, 2024 at 04:10:59PM +0100, Joey Gouly wrote:
+static bool fault_from_pkey(unsigned long esr, struct vm_area_struct *vma,
+			unsigned int mm_flags)
+{
+	unsigned long iss2 = ESR_ELx_ISS2(esr);
+
+	if (!system_supports_poe())
+		return false;
+
+	if (iss2 & ESR_ELx_Overlay)
+		return true;
Does this need an is_data_abort() && is_instruction_abort() check?
Overlay doesn't appear to be defined for all exception types and it
wasn't clear enough to me that the callers have done this check.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help