Re: [PATCH v2 13/17] selftests: vdso: Don't hard-code location of vDSO sources

From
Jason A. Donenfeld <Jason@zx2c4.com>
Date
2024-08-26 07:26:54
Also in
linux-arch, linux-fsdevel, linux-kselftest, linux-mm, linux-trace-kernel, lkml
Reply to
Christophe Leroy, 2024-08-22
On Thu, Aug 22, 2024 at 09:13:21AM +0200, Christophe Leroy wrote:
Architectures use different location for vDSO sources:
	arch/mips/vdso
	arch/sparc/vdso
	arch/arm64/kernel/vdso
	arch/riscv/kernel/vdso
	arch/csky/kernel/vdso
	arch/x86/um/vdso
	arch/x86/entry/vdso
	arch/powerpc/kernel/vdso
	arch/arm/vdso
	arch/loongarch/vdso

Don't hard-code vdso sources location in selftest Makefile,
instead create a vdso/ symbolic link in tools/arch/$arch/ and
update Makefile accordingly.
That seems like a good way of handling it. As archs add their
implementations, they can just add the symlink and do no more work. It
will also make review slightly easier: if I don't see the symlink added,
I'll know the submitter didn't actually test their chacha :-P.

I'll take this into my random.git tree now as a fix.

Jason
Thread (65 messages) 65 messages, 10 authors, last reply 2024-08-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help