Re: [PATCH] crash: Default to CRASH_DUMP=n when support for it is unlikely

From
Baoquan He <hidden>
Date
2024-08-30 03:16:06
Also in
kexec, linux-sh, lkml
Reply to
Dave Vasilevsky, 2024-08-23
Hi Dave,

On 08/23/24 at 08:51am, Dave Vasilevsky wrote:
......snip..
quoted hunk ↗ jump to hunk
diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
index 1aa3c4a0c5b2..b04cfa23378c 100644
--- a/arch/sh/Kconfig
+++ b/arch/sh/Kconfig
@@ -549,6 +549,9 @@ config ARCH_SUPPORTS_KEXEC
 config ARCH_SUPPORTS_CRASH_DUMP
 	def_bool BROKEN_ON_SMP
 
+config ARCH_DEFAULT_CRASH_DUMP
+	def_bool n
If we don't add ARCH_DEFAULT_CRASH_DUMP at all in sh arch, the
CRASH_DUMP will be off by default according to the below new definition
of CRASH_DUMP?

Thanks
Baoquan
quoted hunk ↗ jump to hunk
+
 config ARCH_SUPPORTS_KEXEC_JUMP
 	def_bool y
 
......  
quoted hunk ↗ jump to hunk
diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec
index 6c34e63c88ff..4d111f871951 100644
--- a/kernel/Kconfig.kexec
+++ b/kernel/Kconfig.kexec
@@ -97,7 +97,7 @@ config KEXEC_JUMP
 
 config CRASH_DUMP
 	bool "kernel crash dumps"
-	default y
+	default ARCH_DEFAULT_CRASH_DUMP
 	depends on ARCH_SUPPORTS_CRASH_DUMP
 	depends on KEXEC_CORE
 	select VMCORE_INFO
-- 
2.34.1
  
Thread (17 messages) 17 messages, 5 authors, last reply 2024-09-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help