Thread (42 messages) 42 messages, 3 authors, 2024-09-05

Re: [PATCH v2 03/14] powerpc: assert_pte_locked() use pte_offset_map_ro_nolock()

From: David Hildenbrand <hidden>
Date: 2024-08-26 15:28:32
Also in: linux-arm-kernel, linux-mm, lkml

On 22.08.24 09:13, Qi Zheng wrote:
quoted hunk ↗ jump to hunk
In assert_pte_locked(), we just get the ptl and assert if it was already
held, so convert it to using pte_offset_map_ro_nolock().

Signed-off-by: Qi Zheng <redacted>
---
  arch/powerpc/mm/pgtable.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
index 7316396e452d8..61df5aed79894 100644
--- a/arch/powerpc/mm/pgtable.c
+++ b/arch/powerpc/mm/pgtable.c
@@ -398,7 +398,7 @@ void assert_pte_locked(struct mm_struct *mm, unsigned long addr)
  	 */
  	if (pmd_none(*pmd))
  		return;
-	pte = pte_offset_map_nolock(mm, pmd, addr, &ptl);
+	pte = pte_offset_map_ro_nolock(mm, pmd, addr, &ptl);
  	BUG_ON(!pte);
  	assert_spin_locked(ptl);
  	pte_unmap(pte);
Acked-by: David Hildenbrand <redacted>

-- 
Cheers,

David / dhildenb

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help