Thread (6 messages) 6 messages, 4 authors, 2024-08-27

Re: [PATCH v2] ata: pata_macio: Use WARN instead of BUG

From: Sergei Shtylyov <hidden>
Date: 2024-08-21 21:14:16
Also in: linux-ide, lkml

On 8/20/24 6:04 AM, Michael Ellerman wrote:
The overflow/underflow conditions in pata_macio_qc_prep() should never
happen. But if they do there's no need to kill the system entirely, a
WARN and failing the IO request should be sufficient and might allow the
system to keep running.
   WARN*() can kill your system with panic_on_warn -- Android is particularly
fond of this kernel parameter but I guess it's not your case... :-)
   Greg KH usually advices against using these macros. :-)
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
[...]

   Please do CC me on the PATA driver patches! This one circumvented my review
(again)... :-/

MBR, Sergey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help