Re: [PATCH] cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2024-07-22 07:13:55
Also in:
kernel-janitors, linux-pm, lkml
Jeff Johnson [off-list ref] writes:
quoted hunk ↗ jump to hunk
With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/ppc-cbe-cpufreq.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/powernv-cpufreq.o Add the missing invocation of the MODULE_DESCRIPTION() macro to all files which have a MODULE_LICENSE(). This includes three additional files which, although they did not produce a warning with the powerpc allmodconfig configuration, may cause this warning with specific options enabled in the kernel configuration. Signed-off-by: Jeff Johnson <redacted> --- Corrections to these descriptions are welcomed. I'm not an expert in this code so in most cases I've taken these descriptions directly from code comments, Kconfig descriptions, or git logs. History has shown that in some cases these are originally wrong due to cut-n-paste errors, and in other cases the drivers have evolved such that the original information is no longer accurate. --- drivers/cpufreq/maple-cpufreq.c | 1 + drivers/cpufreq/pasemi-cpufreq.c | 1 + drivers/cpufreq/pmac64-cpufreq.c | 1 + drivers/cpufreq/powernv-cpufreq.c | 1 + drivers/cpufreq/ppc_cbe_cpufreq.c | 1 + 5 files changed, 5 insertions(+)diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c index f9306410a07f..19ca7f874d28 100644 --- a/drivers/cpufreq/maple-cpufreq.c +++ b/drivers/cpufreq/maple-cpufreq.c@@ -238,4 +238,5 @@ static int __init maple_cpufreq_init(void) module_init(maple_cpufreq_init); +MODULE_DESCRIPTION("cpufreq driver for Maple 970FX Evaluation Board");
Can you change this one to: "cpufreq driver for Maple 970FX/970MP boards"); It looks for both those CPUs in probe.
quoted hunk ↗ jump to hunk
diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index fddbd1ea1635..e923f717e1d7 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c@@ -1162,5 +1162,6 @@ static void __exit powernv_cpufreq_exit(void) } module_exit(powernv_cpufreq_exit); +MODULE_DESCRIPTION("cpufreq driver for the IBM POWER processors");
This one's tricky, because it probes based on the device tree, though it is restricted to CONFIG_POWERNV. It also supports non-IBM CPUs in theory at least. Maybe something like: "cpufreq driver for IBM/OpenPOWER powernv systems"); cheers