Thread (60 messages) 60 messages, 7 authors, 2024-07-23

Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned

From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Date: 2024-07-19 16:57:26
Also in: linux-acpi, linux-arch, linux-arm-kernel, linux-cxl, linux-devicetree, linux-mips, linux-mm, linux-riscv, linux-s390, linux-sh, lkml, loongarch, nvdimm, sparclinux

On Tue, 16 Jul 2024 14:13:40 +0300
Mike Rapoport [off-list ref] wrote:
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>

CPU id cannot be negative.

Making it unsigned also aligns with declarations in
include/asm-generic/numa.h used by arm64 and riscv and allows sharing
numa emulation code with these architectures.

Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Makes sense for both reasons. FWIW given how simple it is.

Maybe worth bringing a few more functions inline with this?
Probably something for another day given we don't care about the
inconsistency for this series.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help