Re: [PATCH v3 1/1] x86/elf: Add a new .note section containing xfeatures buffer layout info to x86 core files
From: Thomas Gleixner <hidden>
Date: 2024-07-13 10:42:16
Also in:
linux-mm, linux-toolchains, lkml
On Fri, Jul 12 2024 at 15:16, Vignesh Balasubramanian wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h index 1fb83d477..cad37090b 100644 --- a/arch/x86/include/asm/elf.h +++ b/arch/x86/include/asm/elf.h@@ -13,6 +13,15 @@ #include <asm/auxvec.h> #include <asm/fsgsbase.h> +struct xfeat_component { + u32 type; + u32 size; + u32 offset; + u32 flags; +} __packed; + +_Static_assert(sizeof(struct xfeat_component)%4 == 0, "xfeat_component is not aligned");
This struct is only used in xstate.c and asm/elf.h is not a UAPI
header. So what's the point of declaring it in the header instead of
xtsate.c?
If this needs to provided for user space consumption, then it want's to
be in a UAPI header, no?
Thanks,
tglx